Merged
Conversation
Dockerfile: use ci instead of install
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - run: | ||
| name: App npm install | ||
| command: npm install | ||
| command: npm ci |
There was a problem hiding this comment.
[correctness]
Switching from npm install to npm ci is a good choice for CI environments as it ensures a clean and consistent installation of dependencies based on the package-lock.json. However, ensure that the package-lock.json is up-to-date and correctly reflects the desired state of dependencies, as npm ci will fail if there are any discrepancies.
| RUN npm config set unsafe-perm true | ||
| RUN git config --global url."https://git@".insteadOf git:// | ||
| RUN npm install | ||
| RUN npm ci |
There was a problem hiding this comment.
[correctness]
Switching from npm install to npm ci is a good practice for CI/CD environments as it ensures a clean install based on the package-lock.json. However, ensure that the package-lock.json is up-to-date and committed to the repository to avoid potential discrepancies between local and CI environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-build package lock for tc-core-library-js